Re: Re: [PATCH 1/6 v2] dvbsky, montage dvb-s/s2 TS202x tuner and M88DS3103demodulator driver

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



2012-04-27 22:03:20 nibble.max@xxxxxxxxx
>Em 27-04-2012 04:06, nibble.max escreveu:
>> ---
>>  drivers/media/dvb/frontends/Kconfig          |   14 +
>>  drivers/media/dvb/frontends/Makefile         |    3 +
>>  drivers/media/dvb/frontends/m88ds3103.c      | 1153 ++++++++++++++++++++++++++
>>  drivers/media/dvb/frontends/m88ds3103.h      |   67 ++
>>  drivers/media/dvb/frontends/m88ds3103_priv.h |  413 +++++++++
>>  drivers/media/dvb/frontends/m88ts202x.c      |  590 +++++++++++++
>>  drivers/media/dvb/frontends/m88ts202x.h      |   63 ++
>>  7 files changed, 2303 insertions(+)
>>  create mode 100644 drivers/media/dvb/frontends/m88ds3103.c
>>  create mode 100644 drivers/media/dvb/frontends/m88ds3103.h
>>  create mode 100644 drivers/media/dvb/frontends/m88ds3103_priv.h
>>  create mode 100644 drivers/media/dvb/frontends/m88ts202x.c
>>  create mode 100644 drivers/media/dvb/frontends/m88ts202x.h
>
>No, this is not what we've agreed. You should, instead, take Konstantin's driver, 
>breaking it into two separate ones, without touching the copyrights. Then, apply
>what else is needed for ds3103/ts2123.
Hello Mauro,

Should I need Konstantin's agreement to do that?
Using the seperate tuner and demod, I need to change the codes which use the ds3000 frontend.
How can I test the code to confirm that these codes are right without these hardwards?

If I can not do this work, the new m88ds3103 and m88ts2022 code can not be patched in the upstream.
It seems i go to a dead lock, doesn't it?

Br,
Max
>
>> diff --git a/drivers/media/dvb/frontends/m88ds3103.c b/drivers/media/dvb/frontends/m88ds3103.c
>> new file mode 100644
>> index 0000000..392cada
>> --- /dev/null
>> +++ b/drivers/media/dvb/frontends/m88ds3103.c
>> @@ -0,0 +1,1153 @@
>> +/*
>> +    Montage Technology M88DS3103/3000 - DVBS/S2 Satellite demod driver
>> +
>> +    Copyright (C) 2011 Max nibble<nibble.max@xxxxxxxxx>
>
>Adding your copyright like that only justifies if you make significant contributions
>to the code. Adding support for a new card or a new chip within the same chip family
>in general don't fit on that. 
>
>If Konstantin is ok, you may, instead, add, at the bottom of the copyright list, something like:
>
>    Copyright (C) 2011 Max nibble<nibble.max@xxxxxxxxx>
>		- Add support for ds3103
>
>> +    Copyright (C) 2010 Montage Technology<www.montage-tech.com>
>> +    Fix some bug and add M88DS3103 code, M88DS3000 code based on DS3000.c.
>> +
>> +    Copyright (C) 2009 Konstantin Dimitrov <kosio.dimitrov@xxxxxxxxx>
>> +
>> +    Copyright (C) 2009 TurboSight.com
>
>Regards,
>Mauro

--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux