On Friday, April 27, 2012 11:24:43 Jean-Francois Moine wrote: > On Fri, 27 Apr 2012 10:20:23 +0200 > Hans Verkuil <hverkuil@xxxxxxxxx> wrote: > > > I might have some time (no guarantees yet) to help with this. It would > > certainly be interesting to add support for the control framework in the > > gspca core. Hmm, perhaps that's a job for the weekend... > > Hi Hans, > > I hope you will not do it! The way gspca treats the controls is static, > quick and very small. The controls in the subdrivers ask only for the > declaration of the controls and functions to send the values to the > webcams. Actually, not all subdrivers have been converted to the new > gspca control handling, but, when done, it will save more memory. And that is exactly what the control framework also does for you. Drivers only have to declare the controls and have a function to set their value. Everything else is handled by the control framework. And you get support for the extended control API for free and also support for control events, plus any future changes/enhancements to how controls are done will be automatically added. Not to mention that it ensures consistent and correct behavior of the control API towards applications. Note that the control code is already part of videodev.ko, so you have that code in memory anyway. So why not use it? Regards, Hans -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
