Hi Laurent Sorry for a slightly delayed reply;-) On Thu, 26 Jan 2012, Laurent Pinchart wrote: [snip] > > > diff --git a/drivers/media/video/sh_mobile_ceu_camera.c > > > b/drivers/media/video/sh_mobile_ceu_camera.c index c51decf..f4eb9e1 > > > 100644 > > > --- a/drivers/media/video/sh_mobile_ceu_camera.c > > > +++ b/drivers/media/video/sh_mobile_ceu_camera.c [snip] > > Looks like sh_mobile_ceu_set_rect() can also be simplified, since there > > bytes_per_line is calculated for data-fetch mode, for which the > > ->bytesperline can also be used? > > Is sh_mobile_ceu_set_rect() guaranteed to be called after try_fmt(), with the > ->bytesperline value set to the correct value for the current format ? I think it is, yes. soc_camera.c always configures the pipeline upon the first .open() call by calling soc_camera_set_fmt(), at which point ->bytesperline is set too. Also, just to avoid confusion - above you meant set_fmt(), not try_fmt(), right? *try* are not supposed to set anything. So, if you agree, either you can do a patch 11/9 or I can do it myself. Or you could do a v3 of just one patch 3/9. Thanks Guennadi --- Guennadi Liakhovetski, Ph.D. Freelance Open-Source Software Developer http://www.open-technology.de/ -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
