Hi Laurent, On Tue, Apr 24, 2012 at 11:08:12AM +0200, Laurent Pinchart wrote: > Hi Sakari, > > On Tuesday 24 April 2012 01:23:06 Sakari Ailus wrote: > > Hi Laurent, > > > > The patch looks good as such on the first glance, but I have another > > question: why are you not using the selections API instead? It's in > > Mauro's tree already. > > You're totally right, we need to convert the selection API. The reason why > I've implemented crop support at the CCDC output was simply that I needed it > for a project and didn't have time to implement the selection API. As the code > works, I considered it would be good to have it upstream until we switch to > the selection API. "Until we switch to the selection API"? The subdev selection API is in Mauro's tree already so I see no reason not to use it. Implementing new functionality in a driver using API we've just marked obsolete is... not pretty. The compatibility code for the old crop ioctls exist, too, so you get exactly the same functionality as well. > > Also, the old S_CROP IOCTL only has been defined for sink pads, not source. > > We're already using crop on source pads on sensors ;-) Is that supposed to work? At the very least least it does not follow the spec. Kind regards, -- Sakari Ailus e-mail: sakari.ailus@xxxxxx jabber/XMPP/Gmail: sailus@xxxxxxxxxxxxxx -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
