Hi Andy,
Thanks for the patch.
On Thursday 19 April 2012 16:48:10 Andy Shevchenko wrote:
> There is no needs to keep .remove under .exit.text. This driver is for a
> standalone chip that could be on any board and connected to any i2c bus.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
> Cc: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx>
> ---
> drivers/media/video/as3645a.c | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/media/video/as3645a.c b/drivers/media/video/as3645a.c
> index 7a3371f..dc2571f 100644
> --- a/drivers/media/video/as3645a.c
> +++ b/drivers/media/video/as3645a.c
> @@ -846,7 +846,7 @@ done:
> return ret;
> }
>
> -static int __exit as3645a_remove(struct i2c_client *client)
> +static int __devexit as3645a_remove(struct i2c_client *client)
What about also marking as3645a_probe() with __devinit ? I might be missing
something though, as we have very few I2C drivers in drivers/media/video with
a probe function marked with __devinit (or remove function marked with
__devexit). Is it time for some cleanup ?
> {
> struct v4l2_subdev *subdev = i2c_get_clientdata(client);
> struct as3645a *flash = to_as3645a(subdev);
> @@ -877,7 +877,7 @@ static struct i2c_driver as3645a_i2c_driver = {
> .pm = &as3645a_pm_ops,
> },
> .probe = as3645a_probe,
> - .remove = __exit_p(as3645a_remove),
> + .remove = __devexit_p(as3645a_remove),
> .id_table = as3645a_id_table,
> };
--
Regards,
Laurent Pinchart
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
