Hi Hans, On Tue, Apr 17, 2012 at 02:41:58PM +0200, Hans Verkuil wrote: > Hi Sakari, > > This patch fixes a regression in VIDIOC_QUERYMENU introduced when the > __s64 value field was added to the union. On a 64-bit system this will > change the size of this v4l2_querymenu structure from 44 to 48 bytes, > thus breaking the ABI. By adding the packed attribute it is working again. Thanks! The original patch wasn't tested on 64-bit systems and I missed the fact that the structure size is aligned to the size of the widest data type used in it to keep alignment set, which Laurent kindly informed me about. So, Acked-by: Sakari Ailus <sakari.ailus@xxxxxx> -- Sakari Ailus e-mail: sakari.ailus@xxxxxx jabber/XMPP/Gmail: sailus@xxxxxxxxxxxxxx -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
