On Tue, 17 Apr 2012 12:09:42 +0200, Sylwester Nawrocki <s.nawrocki@xxxxxxxxxxx> wrote: > This patch adds definition of additional color effects: > - V4L2_COLORFX_AQUA, > - V4L2_COLORFX_ART_FREEZE, > - V4L2_COLORFX_SILHOUETTE, > - V4L2_COLORFX_SOLARIZATION, > - V4L2_COLORFX_ANTIQUE, There starts to be a lot of different color effects with no obvious way to determine which ones the current device actually suppots. Should this not be a menu control instead? > - V4L2_COLORFX_ARBITRARY. > > The control's type in the documentation is changed from 'enum' to 'menu' > - V4L2_CID_COLORFX has always been a menu, not an integer type control. > > The V4L2_COLORFX_ARBITRARY option enables custom color effects, which are > impossible or impractical to define as the menu items. For example, the > devices may provide coefficients for Cb and Cr manipulation, which yield > many permutations, e.g. many slightly different color tints. Such devices > are better exporting their own API for precise control of non-standard > color effects. I don't understand why you need a number for this, if it's going to use another control anyway... ? -- Rémi Denis-Courmont Sent from my collocated server -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
