Hi Tomasz, Thanks for the patch. On Friday 13 April 2012 17:47:53 Tomasz Stanislawski wrote: > From: Sumit Semwal <sumit.semwal@xxxxxx> > > This patch makes changes for adding dma-contig as a dma_buf user. It > provides function implementations for the {attach, detach, map, > unmap}_dmabuf() mem_ops of DMABUF memory type. > > Signed-off-by: Sumit Semwal <sumit.semwal@xxxxxx> > Signed-off-by: Sumit Semwal <sumit.semwal@xxxxxxxxxx> > [author of the original patch] > Signed-off-by: Tomasz Stanislawski <t.stanislaws@xxxxxxxxxxx> > [integration with refactored dma-contig allocator] Pending the comment below, Acked-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx> > +static void vb2_dc_detach_dmabuf(void *mem_priv) > +{ > + struct vb2_dc_buf *buf = mem_priv; > + > + if (WARN_ON(buf->dma_addr)) > + vb2_dc_unmap_dmabuf(buf); This should never happen, and would be a videobuf2 bug otherwise, right ? > + > + /* detach this attachment */ > + dma_buf_detach(buf->db_attach->dmabuf, buf->db_attach); > + kfree(buf); > +} -- Regards, Laurent Pinchart -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html