Re: [GIT PULL FOR v3.5] V4L2 subdev and sensor control changes and SMIA++ driver

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Em 02-04-2012 13:26, Sakari Ailus escreveu:
> Hi Mauro,
> 
> This patchset adds
> 
> - Integer menu controls,
> - Selection IOCTL for subdevs,
> - Sensor control improvements,
> - link_validate() media entity and V4L2 subdev pad ops,
> - OMAP 3 ISP driver improvements,
> - SMIA++ sensor driver and
> - Other V4L2 and media improvements (see individual patches)
> 
> Changes since pull for 3.4 v3:
> 
> - Changed kernel revision and V4L2 changelog dates appropriately for Linux
>   3.5.
> 
> Changes since pull v2:
> 
> - Fixed incorrect 4CC codes in documentation for compresed raw bayer formats
> 
> Changes since pull v1:
> 
> - Correct selection rectangle field description in subdev selection
>   documentation (thanks to Sylwester)
> - Use roundup() instead of ALIGN() in SMIA++ driver
> - Rebased on current media_tree.git/staging/for_v3.4
> 
> ---
> 
> The following changes since commit 296da3cd14db9eb5606924962b2956c9c656dbb0:
> 
>   [media] pwc: poll(): Check that the device has not beem claimed for streaming already (2012-03-27 11:42:04 -0300)
> 
> are available in the git repository at:
>   ssh://linuxtv.org/git/sailus/media_tree.git media-for-3.5
> 
> Jesper Juhl (1):
>       adp1653: Remove unneeded include of version.h
> 
> Laurent Pinchart (2):
>       omap3isp: Prevent pipelines that contain a crashed entity from starting
>       omap3isp: Fix frame number propagation
> 
> Sakari Ailus (37):
>       v4l: Introduce integer menu controls
>       v4l: Document integer menu controls
>       vivi: Add an integer menu test control
>       v4l: VIDIOC_SUBDEV_S_SELECTION and VIDIOC_SUBDEV_G_SELECTION IOCTLs
>       v4l: vdev_to_v4l2_subdev() should have return type "struct v4l2_subdev *"
>       v4l: Check pad number in get try pointer functions
>       v4l: Support s_crop and g_crop through s/g_selection
>       v4l: Add subdev selections documentation: svg and dia files
>       v4l: Add subdev selections documentation

There's something wrong here:

Warning: multiple "IDs" for constraint linkend: vidioc-subdev-g-selection.
Warning: multiple "IDs" for constraint linkend: v4l2-subdev-selection-targets.
Warning: multiple "IDs" for constraint linkend: v4l2-subdev-selection-targets.
Warning: multiple "IDs" for constraint linkend: v4l2-subdev-selection-flags.
Warning: multiple "IDs" for constraint linkend: v4l2-subdev-selection.
No template for "/book/part/chapter/section/section/section/para" (or any of its leaves) exists in the context named "title" in the "en" localization.
No template for "/book/part/chapter/section/section/section/para" (or any of its leaves) exists in the context named "title" in the "en" localization.
Warning: multiple "IDs" for constraint linkend: v4l2-subdev-selection-flags.
Warning: multiple "IDs" for constraint linkend: vidioc-subdev-g-selection.
Warning: multiple "IDs" for constraint linkend: vidioc-subdev-g-selection.
Warning: multiple "IDs" for constraint linkend: vidioc-subdev-g-selection.
Warning: multiple "IDs" for constraint linkend: vidioc-subdev-g-selection.
Warning: multiple "IDs" for constraint linkend: v4l2-subdev-selection-targets.
Warning: multiple "IDs" for constraint linkend: v4l2-subdev-selection-flags.
Warning: multiple "IDs" for constraint linkend: v4l2-subdev-selection.
Error: no ID for constraint linkend: v4l2-jpeg-chroma-subsampling.
Error: no ID for constraint linkend: v4l2-jpeg-chroma-subsampling.
Warning: multiple "IDs" for constraint linkend: v4l2-subdev-selection.

The index will break if there are two places with the same ID's.

Sylvester,

Btw, you also did a similar mistake: you've added a symbol at the API called
v4l2_jpeg_chroma_subsampling, but you didn't create any reference for v4l2-jpeg-chroma-subsampling
at the DocBook. Instead, you've created a jpeg-chroma-subsampling-control ID,
not sure if it is for the same structure.

Sakari/Sylvester,

The building system adds a link for each structure at the media header files
to the corresponding structures inside the DocBook. It also adds it to the
index.

You need to take care that they'll point to the right things when sending us
a DocBook patch.

PS.: As the previous patches are ok, I'll keep them at the tree.

Regards,
Mauro.

>       v4l: Mark VIDIOC_SUBDEV_G_CROP and VIDIOC_SUBDEV_S_CROP obsolete
>       v4l: Image source control class
>       v4l: Image processing control class
>       v4l: Document raw bayer 4CC codes
>       v4l: Add DPCM compressed raw bayer pixel formats
>       media: Add link_validate() op to check links to the sink pad
>       v4l: Improve sub-device documentation for pad ops
>       v4l: Implement v4l2_subdev_link_validate()
>       v4l: Allow changing control handler lock
>       omap3isp: Support additional in-memory compressed bayer formats
>       omap3isp: Move definitions required by board code under include/media.
>       omap3: add definition for CONTROL_CAMERA_PHY_CTRL
>       omap3isp: Move setting constaints above media_entity_pipeline_start
>       omap3isp: Assume media_entity_pipeline_start may fail
>       omap3isp: Add lane configuration to platform data
>       omap3isp: Collect entities that are part of the pipeline
>       omap3isp: Add information on external subdev to struct isp_pipeline
>       omap3isp: Introduce isp_video_check_external_subdevs()
>       omap3isp: Use external rate instead of vpcfg
>       omap3isp: Default link validation for ccp2, csi2, preview and resizer
>       omap3isp: Move CCDC link validation to ccdc_link_validate()
>       omap3isp: Configure CSI-2 phy based on platform data
>       omap3isp: Add resizer data rate configuration to resizer_link_validate
>       omap3isp: Find source pad from external entity
>       smiapp: Generic SMIA++/SMIA PLL calculator
>       smiapp: Add driver
>       omap3isp: Prevent crash at module unload
>       omap3isp: Handle omap3isp_csi2_reset() errors
> 
>  Documentation/DocBook/media/Makefile               |    4 +-
>  Documentation/DocBook/media/v4l/compat.xml         |   26 +
>  Documentation/DocBook/media/v4l/controls.xml       |  168 ++
>  Documentation/DocBook/media/v4l/dev-subdev.xml     |  202 ++-
>  Documentation/DocBook/media/v4l/pixfmt-srggb10.xml |    2 +-
>  .../DocBook/media/v4l/pixfmt-srggb10dpcm8.xml      |   29 +
>  Documentation/DocBook/media/v4l/pixfmt.xml         |    1 +
>  .../media/v4l/subdev-image-processing-crop.dia     |  614 +++++
>  .../media/v4l/subdev-image-processing-crop.svg     |   63 +
>  .../media/v4l/subdev-image-processing-full.dia     | 1588 +++++++++++
>  .../media/v4l/subdev-image-processing-full.svg     |  163 ++
>  ...ubdev-image-processing-scaling-multi-source.dia | 1152 ++++++++
>  ...ubdev-image-processing-scaling-multi-source.svg |  116 +
>  Documentation/DocBook/media/v4l/v4l2.xml           |   21 +
>  .../DocBook/media/v4l/vidioc-g-ext-ctrls.xml       |   12 +
>  .../DocBook/media/v4l/vidioc-queryctrl.xml         |   39 +-
>  .../DocBook/media/v4l/vidioc-subdev-g-crop.xml     |    9 +-
>  .../media/v4l/vidioc-subdev-g-selection.xml        |  228 ++
>  Documentation/media-framework.txt                  |   19 +
>  Documentation/video4linux/4CCs.txt                 |   32 +
>  Documentation/video4linux/v4l2-framework.txt       |   21 +
>  arch/arm/mach-omap2/control.h                      |    1 +
>  drivers/media/media-entity.c                       |   57 +-
>  drivers/media/video/Kconfig                        |    3 +
>  drivers/media/video/Makefile                       |    3 +
>  drivers/media/video/adp1653.c                      |   11 +-
>  drivers/media/video/omap3isp/isp.c                 |   67 +-
>  drivers/media/video/omap3isp/isp.h                 |   11 +-
>  drivers/media/video/omap3isp/ispccdc.c             |   74 +-
>  drivers/media/video/omap3isp/ispccdc.h             |   10 -
>  drivers/media/video/omap3isp/ispccp2.c             |   24 +-
>  drivers/media/video/omap3isp/ispcsi2.c             |   21 +-
>  drivers/media/video/omap3isp/ispcsi2.h             |    1 -
>  drivers/media/video/omap3isp/ispcsiphy.c           |  172 +-
>  drivers/media/video/omap3isp/ispcsiphy.h           |   25 +-
>  drivers/media/video/omap3isp/isppreview.c          |    1 +
>  drivers/media/video/omap3isp/ispresizer.c          |   16 +
>  drivers/media/video/omap3isp/ispvideo.c            |  341 ++--
>  drivers/media/video/omap3isp/ispvideo.h            |    5 +
>  drivers/media/video/smiapp-pll.c                   |  419 +++
>  drivers/media/video/smiapp-pll.h                   |  103 +
>  drivers/media/video/smiapp/Kconfig                 |   13 +
>  drivers/media/video/smiapp/Makefile                |    3 +
>  drivers/media/video/smiapp/smiapp-core.c           | 2832 ++++++++++++++++++++
>  drivers/media/video/smiapp/smiapp-debug.h          |   32 +
>  drivers/media/video/smiapp/smiapp-limits.c         |  132 +
>  drivers/media/video/smiapp/smiapp-limits.h         |  128 +
>  drivers/media/video/smiapp/smiapp-quirk.c          |  264 ++
>  drivers/media/video/smiapp/smiapp-quirk.h          |   72 +
>  drivers/media/video/smiapp/smiapp-reg-defs.h       |  503 ++++
>  drivers/media/video/smiapp/smiapp-reg.h            |  122 +
>  drivers/media/video/smiapp/smiapp-regs.c           |  213 ++
>  drivers/media/video/smiapp/smiapp-regs.h           |   46 +
>  drivers/media/video/smiapp/smiapp.h                |  251 ++
>  drivers/media/video/v4l2-ctrls.c                   |  133 +-
>  drivers/media/video/v4l2-subdev.c                  |  143 +-
>  drivers/media/video/vivi.c                         |   26 +-
>  include/linux/v4l2-subdev.h                        |   41 +
>  include/linux/videodev2.h                          |   26 +-
>  include/media/media-entity.h                       |    5 +-
>  include/media/omap3isp.h                           |   29 +
>  include/media/smiapp.h                             |   83 +
>  include/media/v4l2-ctrls.h                         |   15 +-
>  include/media/v4l2-subdev.h                        |   49 +-
>  64 files changed, 10554 insertions(+), 481 deletions(-)
>  create mode 100644 Documentation/DocBook/media/v4l/pixfmt-srggb10dpcm8.xml
>  create mode 100644 Documentation/DocBook/media/v4l/subdev-image-processing-crop.dia
>  create mode 100644 Documentation/DocBook/media/v4l/subdev-image-processing-crop.svg
>  create mode 100644 Documentation/DocBook/media/v4l/subdev-image-processing-full.dia
>  create mode 100644 Documentation/DocBook/media/v4l/subdev-image-processing-full.svg
>  create mode 100644 Documentation/DocBook/media/v4l/subdev-image-processing-scaling-multi-source.dia
>  create mode 100644 Documentation/DocBook/media/v4l/subdev-image-processing-scaling-multi-source.svg
>  create mode 100644 Documentation/DocBook/media/v4l/vidioc-subdev-g-selection.xml
>  create mode 100644 Documentation/video4linux/4CCs.txt
>  create mode 100644 drivers/media/video/smiapp-pll.c
>  create mode 100644 drivers/media/video/smiapp-pll.h
>  create mode 100644 drivers/media/video/smiapp/Kconfig
>  create mode 100644 drivers/media/video/smiapp/Makefile
>  create mode 100644 drivers/media/video/smiapp/smiapp-core.c
>  create mode 100644 drivers/media/video/smiapp/smiapp-debug.h
>  create mode 100644 drivers/media/video/smiapp/smiapp-limits.c
>  create mode 100644 drivers/media/video/smiapp/smiapp-limits.h
>  create mode 100644 drivers/media/video/smiapp/smiapp-quirk.c
>  create mode 100644 drivers/media/video/smiapp/smiapp-quirk.h
>  create mode 100644 drivers/media/video/smiapp/smiapp-reg-defs.h
>  create mode 100644 drivers/media/video/smiapp/smiapp-reg.h
>  create mode 100644 drivers/media/video/smiapp/smiapp-regs.c
>  create mode 100644 drivers/media/video/smiapp/smiapp-regs.h
>  create mode 100644 drivers/media/video/smiapp/smiapp.h
>  create mode 100644 include/media/smiapp.h
> 
> 
> 
> Kind regards,
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux