Prior to this patch the stk-webcam driver was enabling the vflip and mirror bits in the sensor by default. Which only is the right thing to do if the sensor is actually mounted upside down, which it usually is not. Actually we've received upside down reports for both usb-ids which this driver supports, one for an "ASUSTeK Computer Inc." "A3H" laptop with a build in 174f:a311 webcam, and one for an "To Be Filled By O.E.M." "Z96FM" laptop with a build in 05e1:0501 webcam. Signed-off-by: Hans de Goede <hdegoede@xxxxxxxxxx> --- drivers/media/video/stk-webcam.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/media/video/stk-webcam.c b/drivers/media/video/stk-webcam.c index d427f84..86a0fc5 100644 --- a/drivers/media/video/stk-webcam.c +++ b/drivers/media/video/stk-webcam.c @@ -38,13 +38,13 @@ #include "stk-webcam.h" -static bool hflip = 1; +static bool hflip; module_param(hflip, bool, 0444); -MODULE_PARM_DESC(hflip, "Horizontal image flip (mirror). Defaults to 1"); +MODULE_PARM_DESC(hflip, "Horizontal image flip (mirror). Defaults to 0"); -static bool vflip = 1; +static bool vflip; module_param(vflip, bool, 0444); -MODULE_PARM_DESC(vflip, "Vertical image flip. Defaults to 1"); +MODULE_PARM_DESC(vflip, "Vertical image flip. Defaults to 0"); static int debug; module_param(debug, int, 0444); -- 1.7.9.3 -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
