Damn!! here it is again, corrected. I'm really sorry, thanks for the patience :)
> Also, I think the name should be something like "AVerMedia Twinstar
> (A825)" since Avermedia code names usually are "Axxx".
I thought the name between parenthesis was after the usb pvid value so
I used that value.
This is what I get with lsusb:
# lsusb
bus 003 Device 002: ID 07ca:0825 AVerMedia Technologies, Inc.
I've modified the name with "AVermedia Twinstar (A825) as you
suggested, should I revert it?
--- drivers/media/dvb/dvb-usb/af9035.c.origin 2012-04-05
15:31:55.431075058 +0200
+++ drivers/media/dvb/dvb-usb/af9035.c 2012-04-05 15:26:44.483073976 +0200
@@ -827,6 +827,7 @@ enum af9035_id_entry {
AF9035_07CA_B835,
AF9035_07CA_1867,
AF9035_07CA_A867,
+ AF9035_07CA_0825,
};
static struct usb_device_id af9035_id[] = {
@@ -844,6 +845,8 @@ static struct usb_device_id af9035_id[]
USB_DEVICE(USB_VID_AVERMEDIA, USB_PID_AVERMEDIA_1867)},
[AF9035_07CA_A867] = {
USB_DEVICE(USB_VID_AVERMEDIA, USB_PID_AVERMEDIA_A867)},
+ [AF9035_07CA_0825] = {
+ USB_DEVICE(USB_VID_AVERMEDIA, USB_PID_AVERMEDIA_TWINSTAR)},
{},
};
@@ -886,7 +889,7 @@ static struct dvb_usb_device_properties
.i2c_algo = &af9035_i2c_algo,
- .num_device_descs = 4,
+ .num_device_descs = 5,
.devices = {
{
.name = "TerraTec Cinergy T Stick",
@@ -911,6 +914,10 @@ static struct dvb_usb_device_properties
&af9035_id[AF9035_07CA_1867],
&af9035_id[AF9035_07CA_A867],
},
+ }, {
+ .name = "AVerMedia Twinstar (A825)",
+ .cold_ids = {
+ &af9035_id[AF9035_07CA_0825],
},
}
},
--- drivers/media/dvb/dvb-usb/dvb-usb-ids.h.origin 2012-04-05
15:32:15.229075128 +0200
+++ drivers/media/dvb/dvb-usb/dvb-usb-ids.h 2012-04-05
15:27:22.775074099 +0200
@@ -228,6 +228,7 @@
#define USB_PID_AVERMEDIA_B835 0xb835
#define USB_PID_AVERMEDIA_1867 0x1867
#define USB_PID_AVERMEDIA_A867 0xa867
+#define USB_PID_AVERMEDIA_TWINSTAR 0x0825
#define USB_PID_TECHNOTREND_CONNECT_S2400 0x3006
#define USB_PID_TECHNOTREND_CONNECT_CT3650 0x300d
#define USB_PID_TERRATEC_CINERGY_DT_XS_DIVERSITY 0x005a
Signed-off-by: Pierangelo Terzulli <pierigno@xxxxxxxxx>
Il 05 aprile 2012 18:20, Gianluca Gennari <gennarone@xxxxxxxxx> ha scritto:
> Thanks Pierangelo,
> but there are still issues with your patch.
> See in-line comments.
>
> Il 05/04/2012 16:34, pierigno ha scritto:
>> gosh!! I pasted the wrong patch, sorry for the noise, here it is (it
>> should be applied against
>> http://git.linuxtv.org/anttip/media_tree.git/shortlog/refs/heads/af9035_experimental):
>>
>>
>> --- drivers/media/dvb/dvb-usb/af9035.c.origin 2012-04-05
>> 15:31:55.431075058 +0200
>> +++ drivers/media/dvb/dvb-usb/af9035.c 2012-04-05 15:26:44.483073976 +0200
>> @@ -827,6 +827,7 @@ enum af9035_id_entry {
>> AF9035_07CA_B835,
>> AF9035_07CA_1867,
>> AF9035_07CA_A867,
>> + AF9035_07CA_0825,
>
> here you define AF9035_07CA_0825....
>
>> };
>>
>> static struct usb_device_id af9035_id[] = {
>> @@ -844,6 +845,8 @@ static struct usb_device_id af9035_id[]
>> USB_DEVICE(USB_VID_AVERMEDIA, USB_PID_AVERMEDIA_1867)},
>> [AF9035_07CA_A867] = {
>> USB_DEVICE(USB_VID_AVERMEDIA, USB_PID_AVERMEDIA_A867)},
>> + [AF9035_07CA_0825] = {
>> + USB_DEVICE(USB_VID_AVERMEDIA, USB_PID_AVERMEDIA_TWINSTAR)},
>> {},
>> };
>>
>> @@ -886,7 +889,7 @@ static struct dvb_usb_device_properties
>>
>> .i2c_algo = &af9035_i2c_algo,
>>
>> - .num_device_descs = 4,
>> + .num_device_descs = 5,
>> .devices = {
>> {
>> .name = "TerraTec Cinergy T Stick",
>> @@ -911,6 +914,10 @@ static struct dvb_usb_device_properties
>> &af9035_id[AF9035_07CA_1867],
>> &af9035_id[AF9035_07CA_A867],
>> },
>> + }, {
>> + .name = "AVerMedia Twinstar (0825)",
>> + .cold_ids = {
>> + &af9035_id[AF9035_07CA_0235],
>
> ... and here you use AF9035_07CA_0235!
> Also, I think the name should be something like "AVerMedia Twinstar
> (A825)" since Avermedia code names usually are "Axxx".
>
>
>> },
>> }
>> },
>>
>> --- drivers/media/dvb/dvb-usb/dvb-usb-ids.h.origin 2012-04-05
>> 15:32:15.229075128 +0200
>> +++ drivers/media/dvb/dvb-usb/dvb-usb-ids.h 2012-04-05 15:27:22.775074099 +0200
>> @@ -228,6 +228,7 @@
>> #define USB_PID_AVERMEDIA_B835 0xb835
>> #define USB_PID_AVERMEDIA_1867 0x1867
>> #define USB_PID_AVERMEDIA_A867 0xa867
>> +#define USB_PID_AVERMEDIA_TWINSTAR 0x0825
>> #define USB_PID_TECHNOTREND_CONNECT_S2400 0x3006
>> #define USB_PID_TECHNOTREND_CONNECT_CT3650 0x300d
>> #define USB_PID_TERRATEC_CINERGY_DT_XS_DIVERSITY 0x005a
>>
>>
>
> Also, remember to put your "Signed-off-by" line on the patch.
>
> Regards,
> Gianluca
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
