On Mon, 02 Apr 2012 20:03:08 +0300 Antti Palosaari <crope@xxxxxx> wrote: > On 02.04.2012 19:18, Michael Büsch wrote: > > This adds Fitipower fc0011 tuner support to the af9035 driver. > > > > Signed-off-by: Michael Buesch<m@xxxxxxx> > > Applied, thanks! > http://git.linuxtv.org/anttip/media_tree.git/shortlog/refs/heads/af9035_experimental > > And same checkpatch.pl issue here. > You can ran checkpatch like that: > git diff | ./scripts/checkpatch.pl - > git diff --cached | ./scripts/checkpatch.pl - > ./scripts/checkpatch.pl --file drivers/media/dvb/dvb-usb/af9035.c > > For that driver it complains you are using wrong sleep (msleep(10)). > Correct sleep for that case is something like usleep_range(10000, > 100000); which means as sleep at least 10ms but it does not matter if > you sleep even 100ms. The wider range the better chance for Kernel to > optimize power saving. There was usleep_range() already used inside that > module. Ok, the sleep warning is the only remotely sane checkpatch warning for these patches. So I will send a separate patch to convert those sleeps. -- Greetings, Michael. PGP encryption is encouraged / 908D8B0E
Attachment:
signature.asc
Description: PGP signature
