On 02.04.2012 00:19, Hans-Frieder Vogt wrote:
Implementation of af9033_read_ber and af9033_read_ucblocks functions.
Signed-off-by: Hans-Frieder Vogt<hfvogt@xxxxxxx>
drivers/media/dvb/dvb-usb/af9033.c | 68 +++++++++++++++++++++++++++++++++++--
Same wrong path issue.
+ /* only update data every half second */
+ if (time_after(jiffies, state->last_stat_check + 500 * HZ / 1000)) {
500 * HZ looks odd. I suspect correct way is to use some macros for
that. See af9013 example usage of jiffies or explain the reason why 500
* HZ :)
+ sw = ~sw;
I don't see any reason for that?
It looked somehow complex, but I trust those calculations are kinda correct.
IMHO it is enough to put random raw number from register to UCB and BER
counters. Random numbers are good enough unless you are making
measurement equipment. But off-course correct calculations are allowed.
regards
Antti
--
http://palosaari.fi/
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
