On Sat, 2012-03-31 at 11:18 +0200, Hans Verkuil wrote:
> Hi Mauro,
>
> When I converted ivtv to the new decoder API I introduced a regression in the
> support of the old channel select API. The patch below fixes this.
>
> Thanks to Martin Dauskardt for reporting this.
>
> Signed-off-by: Hans Verkuil <hans.verkuil@xxxxxxxxx>
Looks good. Thanks Martin and Hans.
Reviewd-by: Andy Walls <awalls@xxxxxxxxxxxxxxxx>
> Regards,
>
> Hans
>
> diff --git a/drivers/media/video/ivtv/ivtv-ioctl.c b/drivers/media/video/ivtv/ivtv-ioctl.c
> index 5452bee..989e556 100644
> --- a/drivers/media/video/ivtv/ivtv-ioctl.c
> +++ b/drivers/media/video/ivtv/ivtv-ioctl.c
> @@ -1763,13 +1763,13 @@ static int ivtv_decoder_ioctls(struct file *filp, unsigned int cmd, void *arg)
> IVTV_DEBUG_IOCTL("AUDIO_CHANNEL_SELECT\n");
> if (iarg > AUDIO_STEREO_SWAPPED)
> return -EINVAL;
> - return v4l2_ctrl_s_ctrl(itv->ctrl_audio_playback, iarg);
> + return v4l2_ctrl_s_ctrl(itv->ctrl_audio_playback, iarg + 1);
>
> case AUDIO_BILINGUAL_CHANNEL_SELECT:
> IVTV_DEBUG_IOCTL("AUDIO_BILINGUAL_CHANNEL_SELECT\n");
> if (iarg > AUDIO_STEREO_SWAPPED)
> return -EINVAL;
> - return v4l2_ctrl_s_ctrl(itv->ctrl_audio_multilingual_playback, iarg);
> + return v4l2_ctrl_s_ctrl(itv->ctrl_audio_multilingual_playback, iarg + 1);
>
> default:
> return -EINVAL;
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
