Hi, This patchset isolates em28xx-input code and turns it into a module, as suggested by Mauro [1]. Contrary to my initial expectations, the patch produces code that's actually cleaner and a slightly less spaghetti. I've tried to make the whole change as clear as possible by splitting it into several patches. This was done to ease the maintainer job and also in the hope that someone cares to review and provide feeback. As I don't have em28xx hardware, I did virtually no test at all so :( drivers/media/video/em28xx/Kconfig | 4 +- drivers/media/video/em28xx/Makefile | 5 +- drivers/media/video/em28xx/em28xx-cards.c | 66 +-------- drivers/media/video/em28xx/em28xx-core.c | 3 + drivers/media/video/em28xx/em28xx-i2c.c | 3 - drivers/media/video/em28xx/em28xx-input.c | 250 +++++++++++++++++++---------- drivers/media/video/em28xx/em28xx.h | 32 +---- 7 files changed, 175 insertions(+), 188 deletions(-) [1] http://www.spinics.net/lists/linux-media/msg45416.html Regards, Ezequiel. -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
