RE: [PATCH] usb: gadget/uvc: Remove non-required locking from 'uvc_queue_next_buffer' routine

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Laurent,

> -----Original Message-----
> From: Laurent Pinchart [mailto:laurent.pinchart@xxxxxxxxxxxxxxxx]
> Sent: Friday, March 23, 2012 3:30 PM
> To: Bhupesh SHARMA
> Cc: balbi@xxxxxx; linux-usb@xxxxxxxxxxxxxxx; spear-devel; linux-
> media@xxxxxxxxxxxxxxx; Greg KH
> Subject: Re: [PATCH] usb: gadget/uvc: Remove non-required locking from
> 'uvc_queue_next_buffer' routine
> 
> Hi Bhupesh,
> 
> On Friday 23 March 2012 17:31:19 Bhupesh SHARMA wrote:
> > On Thursday, March 22, 2012 8:11 PM Gregg KH wrote:
> > > On Thu, Mar 22, 2012 at 10:20:37AM +0530, Bhupesh Sharma wrote:
> > > > This patch removes the non-required spinlock acquire/release
> calls on
> > > > 'queue_irqlock' from 'uvc_queue_next_buffer' routine.
> > > >
> > > > This routine is called from 'video->encode' function (which
> translates
> > > > to either 'uvc_video_encode_bulk' or 'uvc_video_encode_isoc') in
> > > > 'uvc_video.c'. As, the 'video->encode' routines are called with
> > > > 'queue_irqlock' already held, so acquiring a 'queue_irqlock'
> again in
> > > > 'uvc_queue_next_buffer' routine causes a spin lock recursion.
> > > >
> > > > Signed-off-by: Bhupesh Sharma <bhupesh.sharma@xxxxxx>
> > > > Acked-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx>
> > > > ---
> > > >
> > > >  drivers/usb/gadget/uvc_queue.c |    4 +---
> > > >  1 files changed, 1 insertions(+), 3 deletions(-)
> > >
> > > Please use scripts/get_maintainer.pl to determine who to send this
> to
> > > (hint, it's not me...)
> >
> > Can you please pick this USB webcam gadget/peripheral specific patch
> > in your tree?
> 
> Could you please first resubmit with the comments fix as asked by
> Sergei
> Shtylyov ? (s/queue_irqlock/queue->irqlock/)
> 

Ok. I will make the changes as suggested by Sergei and then resubmit
the patch..

Regards,
Bhupesh
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux