On Tue, Mar 20, 2012 at 12:29:52PM +0200, Alex Gershgorin wrote: > This patch add set_rate and round_rate calls to csi_clk. This is needed > to give mx3-camera control over master clock rate to camera. The file you are patching is scheduled for removal in favour for the common clock framework, so you are flogging a dead horse here. I suggest that you wait some time until I finished the i.MX35 patches for this. > +static int csi_set_rate(struct clk *clk, unsigned long rate) > +{ > + unsigned long div; > + unsigned long parent_rate; > + unsigned long pdr2 = __raw_readl(CCM_BASE + CCM_PDR2); > + > + if (pdr2 & (1 << 7)) > + parent_rate = get_rate_arm(); > + else > + parent_rate = get_rate_ppll(); > + > + div = parent_rate / rate; > + > + /* Set clock divider */ > + pdr2 |= ((div - 1) & 0x3f) << 16; btw you forget to clear the divider bits in pdr2 before setting the new values. Sascha -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html