On Tue, Mar 13, 2012 at 1:50 PM, Jean Delvare <khali@xxxxxxxxxxxx> wrote: > struct dvb_usb_device *d can never be NULL so don't waste time > checking for this. > > Rationale: the urb's context is set when usb_fill_bulk_urb() is called > in dib0700_rc_setup(), and never changes after that. d is dereferenced > unconditionally in dib0700_rc_setup() so it can't be NULL or the > driver would crash right away. > > Signed-off-by: Jean Delvare <khali@xxxxxxxxxxxx> > Cc: Mauro Carvalho Chehab <mchehab@xxxxxxxxxxxxx> > Cc: Devin Heitmueller <dheitmueller@xxxxxxxxxxxxxx> > --- > Devin, am I missing something? I think this was just a case of defensive coding where I didn't want to dereference something without validating the pointer first (out of fear that it got called through some other code path that I didn't consider). Devin -- Devin J. Heitmueller - Kernel Labs http://www.kernellabs.com -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
