Hi Laurent,
Laurent Pinchart wrote:
On Wednesday 07 March 2012 19:49:46 Sakari Ailus wrote:
On Wed, Mar 07, 2012 at 11:43:31AM +0100, Laurent Pinchart wrote:
On Tuesday 06 March 2012 18:33:08 Sakari Ailus wrote:
isp_video_check_external_subdevs() will retrieve external subdev's
bits-per-pixel and pixel rate for the use of other ISP subdevs at
streamon
time. isp_video_check_external_subdevs() is called after pipeline
validation.
Signed-off-by: Sakari Ailus<sakari.ailus@xxxxxx>
---
drivers/media/video/omap3isp/ispvideo.c | 75
++++++++++++++++++++++++++++
1 files changed, 75 insertions(+), 0 deletions(-)
diff --git a/drivers/media/video/omap3isp/ispvideo.c
b/drivers/media/video/omap3isp/ispvideo.c index 4bc9cca..ef5c770 100644
--- a/drivers/media/video/omap3isp/ispvideo.c
+++ b/drivers/media/video/omap3isp/ispvideo.c
@@ -934,6 +934,77 @@ isp_video_dqbuf(struct file *file, void *fh, struct
v4l2_buffer *b) file->f_flags& O_NONBLOCK);
}
+static int isp_video_check_external_subdevs(struct isp_pipeline *pipe)
+{
+ struct isp_device *isp =
+ container_of(pipe, struct isp_video, pipe)->isp;
Any reason not to pass isp_device * from the caller to this function ?
I didn't simply because it was unnecessary. Should I? "pipe" is needed in
any case.
It will look simpler (in my opinion), and will probably generate less code, so
I think you should.
I'll change that for a new version tomorrow.
--
Sakari Ailus
sakari.ailus@xxxxxx
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
