Hi Sakari, On Sunday 04 March 2012 17:01:30 Sakari Ailus wrote: > Laurent Pinchart wrote: > > On Sunday 04 March 2012 00:37:07 Sakari Ailus wrote: > >> On Sat, Mar 03, 2012 at 04:28:14PM +0100, Laurent Pinchart wrote: > >>> Add a generic helper function to compute PLL parameters for PLL found in > >>> several Aptina sensors. > > > > [snip] > > > >>> diff --git a/drivers/media/video/aptina-pll.c > >>> b/drivers/media/video/aptina-pll.c new file mode 100644 > >>> index 0000000..55e4a40 > >>> --- /dev/null > >>> +++ b/drivers/media/video/aptina-pll.c > > > > [snip] > > > >>> +int aptina_pll_configure(struct device *dev, struct aptina_pll *pll, > >>> + const struct aptina_pll_limits *limits) > >> > >> I've done the same to the SMIA++ PLL: it can be used separately from the > >> driver now; it'll be part of the next patchset. > >> > >> Do you think it could make sense to swap pll and limits parameters? > > > > Why ? :-) > > Uh, I have it that way. ;-) Also both dev and limits contain perhaps > less interesting or const information than pll, which contains both > input and output parameters. You're lucky, I'm in a good mood, I'll change that ;-) -- Regards, Laurent Pinchart -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
