Re: [PATCH v2 2/6] media: i.MX27 camera: Use list_first_entry() whenever possible.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Javier

On Wed, 22 Feb 2012, Javier Martin wrote:

> Signed-off-by: Javier Martin <javier.martin@xxxxxxxxxxxxxxxxx>
> ---
>  Changes since v1:
>  - Adapt to [PATCH v4 4/4] media i.MX27 camera: handle overflows properly.
> 
> ---
>  drivers/media/video/mx2_camera.c |   26 ++++++++++++--------------
>  1 files changed, 12 insertions(+), 14 deletions(-)
> 
> diff --git a/drivers/media/video/mx2_camera.c b/drivers/media/video/mx2_camera.c
> index 0ade14e..7793264 100644
> --- a/drivers/media/video/mx2_camera.c
> +++ b/drivers/media/video/mx2_camera.c

[snip]

> @@ -1314,7 +1312,7 @@ static irqreturn_t mx27_camera_emma_irq(int irq_emma, void *data)
>  		       pcdev->base_emma + PRP_CNTL);
>  		writel(cntl, pcdev->base_emma + PRP_CNTL);
>  
> -		buf = list_entry(pcdev->active_bufs.next,
> +		buf = list_first_entry(pcdev->active_bufs.next,

This is the only hunk, that you've changed. I'll fix this to be

+		buf = list_first_entry(&pcdev->active_bufs,

>  			struct mx2_buffer, queue);
>  		mx27_camera_frame_done_emma(pcdev,
>  					buf->bufnum, true);

Thanks
Guennadi
---
Guennadi Liakhovetski, Ph.D.
Freelance Open-Source Software Developer
http://www.open-technology.de/
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux