On 21 February 2012 10:24, Guennadi Liakhovetski <g.liakhovetski@xxxxxx> wrote: > On Tue, 21 Feb 2012, javier Martin wrote: > >> On 21 February 2012 09:39, Guennadi Liakhovetski <g.liakhovetski@xxxxxx> wrote: >> > Hi Javier >> > >> > One more thing occurred to me: I don't see anywhere in your patch checking >> > for supported pixel (fourcc) formats. I don't think the PRP can resize >> > arbitrary formats? Most likely these would be limited to some YUV, and, >> > possibly, some RGB formats? >> >> The PrP can resize every format which is supported as input by the eMMa. >> >> Currently, the driver supports 2 input formats: RGB565 and YUV422 >> (YUYV) (see mx27_emma_prp_table[]). > > That's not how I understand it. The mx27_emma_prp_table[] array has 2 > entries: the first one is indeed configured for RGB565, and the second one > is converting input YUV422 to output YUV420. But the former one is not > really that specific format, rather it is a generic configuration used as > a pass-through mode for generic 16-bit formats. > > BTW, does that mean, that on i.MX27 the driver currently doesn't support > 8-bit formats like Bayer? According to the datasheet, the eMMa-PrP only accepts the following input formats when capturing data form the CSI: RGB 16 bpp RGB 32 bpp (unpacked RGB888) YUV 4:2:2 Pixel interleaved YUV 4:4:4 But the driver only supports: - RGB 16bpp which, as you say is used as pass-through mode for generic 16-bit formats. - YUV 422 which is converted to YUV420. I'm sorry, you are right. Since I only use the latter, I hadn't noticed that the resizing engine could in fact have problems with 16bit pass-through mode depending on what 16bit format is really being transfered. What I can do is restricting the use of resizing only to the YUV422 case so that someone who is using the old pass-through mode can add support for resizing later for this format. -- Javier Martin Vista Silicon S.L. CDTUC - FASE C - Oficina S-345 Avda de los Castros s/n 39005- Santander. Cantabria. Spain +34 942 25 32 60 www.vista-silicon.com -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
