Il 20/02/2012 00:46, Chris Rankin ha scritto: > Gianluca, > > One quick comment about your patch; I've noticed that you've declared > two new "GPL only" symbols: > > EXPORT_SYMBOL_GPL(em28xx_capture_start); > EXPORT_SYMBOL_GPL(em28xx_alloc_isoc); > > I'm not sure what the exact policy is with GPL symbols, but I do know > what Al Viro posted recently on the subject: > > http://thread.gmane.org/gmane.linux.file-systems/61372 > > Do we really need EXPORT_SYMBOL_GPL() here? > > Cheers, > Chris > Hi Chris, thanks for the comment. The two new symbols are used in place of the old em28xx_init_isoc and em28xx_uninit_isoc in two different modules (em28xx and em28xx-dvb). Since the old symbols are exported through EXPORT_SYMBOL_GPL(), I did the same with the new ones. This choice should not break any non-GPL module, as this symbols are meant to be used only in the em28xx* modules, just like the old ones. Regards, Gianluca -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
