On 13 February 2012 15:10, Guennadi Liakhovetski <g.liakhovetski@xxxxxx> wrote:
> Hi Javier
>
> On Mon, 13 Feb 2012, Javier Martin wrote:
>
>>
>> Signed-off-by: Javier Martin <javier.martin@xxxxxxxxxxxxxxxxx>
>> ---
>> drivers/media/video/mx2_camera.c | 16 ++++++++--------
>> 1 files changed, 8 insertions(+), 8 deletions(-)
>>
>> diff --git a/drivers/media/video/mx2_camera.c b/drivers/media/video/mx2_camera.c
>> index d9028f1..8ccdb4a 100644
>> --- a/drivers/media/video/mx2_camera.c
>> +++ b/drivers/media/video/mx2_camera.c
>> @@ -1210,7 +1210,9 @@ static struct soc_camera_host_ops mx2_soc_camera_host_ops = {
>> static void mx27_camera_frame_done_emma(struct mx2_camera_dev *pcdev,
>> int bufnum, bool err)
>> {
>> +#ifdef DEBUG
>> struct mx2_fmt_cfg *prp = pcdev->emma_prp;
>> +#endif
>> struct mx2_buffer *buf;
>> struct vb2_buffer *vb;
>> unsigned long phys;
>> @@ -1232,18 +1234,16 @@ static void mx27_camera_frame_done_emma(struct mx2_camera_dev *pcdev,
>> if (prp->cfg.channel == 1) {
>> if (readl(pcdev->base_emma + PRP_DEST_RGB1_PTR +
>> 4 * bufnum) != phys) {
>> - dev_err(pcdev->dev, "%p != %p\n", phys,
>> - readl(pcdev->base_emma +
>> - PRP_DEST_RGB1_PTR +
>> - 4 * bufnum));
>> + dev_err(pcdev->dev, "%p != %p\n", (void *)phys,
>> + (void *)readl(pcdev->base_emma +
>> + PRP_DEST_RGB1_PTR + 4 * bufnum));
>> }
>> } else {
>> if (readl(pcdev->base_emma + PRP_DEST_Y_PTR -
>> 0x14 * bufnum) != phys) {
>> - dev_err(pcdev->dev, "%p != %p\n", phys,
>> - readl(pcdev->base_emma +
>> - PRP_DEST_Y_PTR -
>> - 0x14 * bufnum));
>> + dev_err(pcdev->dev, "%p != %p\n", (void *)phys,
>> + (void *)readl(pcdev->base_emma +
>> + PRP_DEST_Y_PTR - 0x14 * bufnum));
>
> I think, just using %lx would be better.
Fixed.
Please, see v2.
--
Javier Martin
Vista Silicon S.L.
CDTUC - FASE C - Oficina S-345
Avda de los Castros s/n
39005- Santander. Cantabria. Spain
+34 942 25 32 60
www.vista-silicon.com
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
