On Thu, Jan 26, 2012 at 10:00:52AM +0100, Marek Szyprowski wrote: > This patch extracts common reclaim code from __alloc_pages_direct_reclaim() > function to separate function: __perform_reclaim() which can be later used > by alloc_contig_range(). > > Signed-off-by: Marek Szyprowski <m.szyprowski@xxxxxxxxxxx> > Signed-off-by: Kyungmin Park <kyungmin.park@xxxxxxxxxxx> > CC: Michal Nazarewicz <mina86@xxxxxxxxxx> > --- > mm/page_alloc.c | 30 +++++++++++++++++++++--------- > 1 files changed, 21 insertions(+), 9 deletions(-) > > diff --git a/mm/page_alloc.c b/mm/page_alloc.c > index 4e60c0b..e35d06b 100644 > --- a/mm/page_alloc.c > +++ b/mm/page_alloc.c > @@ -2094,16 +2094,13 @@ __alloc_pages_direct_compact(gfp_t gfp_mask, unsigned int order, > } > #endif /* CONFIG_COMPACTION */ > > -/* The really slow allocator path where we enter direct reclaim */ > -static inline struct page * > -__alloc_pages_direct_reclaim(gfp_t gfp_mask, unsigned int order, > - struct zonelist *zonelist, enum zone_type high_zoneidx, > - nodemask_t *nodemask, int alloc_flags, struct zone *preferred_zone, > - int migratetype, unsigned long *did_some_progress) > +/* Perform direct synchronous page reclaim */ > +static inline int > +__perform_reclaim(gfp_t gfp_mask, unsigned int order, struct zonelist *zonelist, > + nodemask_t *nodemask) This function is too large to be inlined. Make it a static int. Once that is fixed add a Acked-by: Mel Gorman <mel@xxxxxxxxx> -- Mel Gorman SUSE Labs -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
