Re: [PATCH 3/8] soc-camera: Add plane layout information to struct soc_mbus_pixelfmt

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Guennadi,

On Thursday 26 January 2012 17:01:15 Guennadi Liakhovetski wrote:
> One more question:
> 
> On Wed, 25 Jan 2012, Laurent Pinchart wrote:
> > To compute the number of bytes per line according to the V4L2
> > specification, we need information about planes layout for planar
> > formats. The new enum soc_mbus_layout convey that information.
> > 
> > Signed-off-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx>
> > ---
> > 
> >  drivers/media/video/atmel-isi.c            |    1 +
> >  drivers/media/video/mx3_camera.c           |    2 +
> >  drivers/media/video/omap1_camera.c         |    8 ++++++
> >  drivers/media/video/pxa_camera.c           |    1 +
> >  drivers/media/video/sh_mobile_ceu_camera.c |    4 +++
> >  drivers/media/video/soc_mediabus.c         |   33
> >  ++++++++++++++++++++++++++++ include/media/soc_mediabus.h              
> >  |   19 ++++++++++++++++ 7 files changed, 68 insertions(+), 0
> >  deletions(-)
> 
> [snip]
> 
> > diff --git a/include/media/soc_mediabus.h b/include/media/soc_mediabus.h
> > index 73f1e7e..18b0864 100644
> > --- a/include/media/soc_mediabus.h
> > +++ b/include/media/soc_mediabus.h
> > @@ -47,6 +47,24 @@ enum soc_mbus_order {
> > 
> >  };
> >  
> >  /**
> > 
> > + * enum soc_mbus_layout - planes layout in memory
> > + * @SOC_MBUS_LAYOUT_PACKED:		color components packed
> > + * @SOC_MBUS_LAYOUT_PLANAR_Y_U_V:	YUV components stored in 3 planes
> > + * @SOC_MBUS_LAYOUT_PLANAR_2Y_C:	YUV components stored in a luma and a
> > + *					chroma plane (C plane is half the size
> > + *					of Y plane)
> > + * @SOC_MBUS_LAYOUT_PLANAR_Y_C:		YUV components stored in a luma 
and a
> > + *					chroma plane (C plane is the same size
> > + *					as Y plane)
> > + */
> > +enum soc_mbus_layout {
> > +	SOC_MBUS_LAYOUT_PACKED = 0,
> > +	SOC_MBUS_LAYOUT_PLANAR_Y_U_V,
> 
> Shouldn't we call this SOC_MBUS_LAYOUT_PLANAR_2Y_U_V?

I'll change that.

-- 
Regards,

Laurent Pinchart
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux