Re: [PATCH 5/8] soc-camera: Add soc_mbus_image_size

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, 25 Jan 2012, Laurent Pinchart wrote:

> The function returns the minimum size of an image for a given number of
> bytes per line (as per the V4L2 specification), width and format.
> 
> Signed-off-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx>
> ---
>  drivers/media/video/soc_mediabus.c |   18 ++++++++++++++++++
>  include/media/soc_mediabus.h       |    2 ++
>  2 files changed, 20 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/media/video/soc_mediabus.c b/drivers/media/video/soc_mediabus.c
> index a707314..3f47774 100644
> --- a/drivers/media/video/soc_mediabus.c
> +++ b/drivers/media/video/soc_mediabus.c
> @@ -397,6 +397,24 @@ s32 soc_mbus_bytes_per_line(u32 width, const struct soc_mbus_pixelfmt *mf)
>  }
>  EXPORT_SYMBOL(soc_mbus_bytes_per_line);
>  
> +s32 soc_mbus_image_size(u32 bytes_per_line, u32 height,
> +			const struct soc_mbus_pixelfmt *mf)

What do you think about making mf the first parameter? :-)

> +{
> +	if (mf->layout == SOC_MBUS_LAYOUT_PACKED)
> +		return bytes_per_line * height;
> +
> +	switch (mf->packing) {
> +	case SOC_MBUS_PACKING_2X8_PADHI:
> +	case SOC_MBUS_PACKING_2X8_PADLO:
> +		return bytes_per_line * height * 2;
> +	case SOC_MBUS_PACKING_1_5X8:
> +		return bytes_per_line * height * 3 / 2;

Hm, confused. Why have you decided to calculate the size based on packing 
and not on layout?

Thanks
Guennadi
---
Guennadi Liakhovetski, Ph.D.
Freelance Open-Source Software Developer
http://www.open-technology.de/
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux