Hi Mauro,
On 01/23/2012 03:22 PM, Mauro Carvalho Chehab wrote:
Em 23-01-2012 11:51, Tomasz Stanislawski escreveu:
Signed-off-by: Tomasz Stanislawski<t.stanislaws@xxxxxxxxxxx>
Signed-off-by: Kyungmin Park<kyungmin.park@xxxxxxxxxxx>
Please better describe this patch. What is it supposing to fix?
Usually compilation error or bugs discovered in previous vb2-dma-contig
patches adding support for dma-buf.
---
drivers/media/video/videobuf2-core.c | 21 +++++++++------------
include/media/videobuf2-core.h | 6 +++---
2 files changed, 12 insertions(+), 15 deletions(-)
diff --git a/drivers/media/video/videobuf2-core.c b/drivers/media/video/videobuf2-core.c
index cb85874..59bb1bc 100644
--- a/drivers/media/video/videobuf2-core.c
+++ b/drivers/media/video/videobuf2-core.c
@@ -119,7 +119,7 @@ static void __vb2_buf_dmabuf_put(struct vb2_buffer *vb)
void *mem_priv = vb->planes[plane].mem_priv;
if (mem_priv) {
- call_memop(q, plane, detach_dmabuf, mem_priv);
+ call_memop(q, detach_dmabuf, mem_priv);
Huh? You're not removing the "plane" parameter on this patch, but, instead,
on a previous patch.
No patch is allowed to break compilation, as it breaks git bisect.
I agree that patches should not break compilation if patches are
accepted to the mainline. There is a big compilation failure at patch 07
where videobuf2-dma-contig.c disappears.
Note that these are proof-of-concept patches for support of dma-buf
exporting/importing dma-buf in V4L2. It would be a waste of time
polished the patches if they are going to be rejected due to design flaws.
Regards,
Tomasz Stanislawski
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
