Re: [RFCv1 2/4] v4l:vb2: add support for shared buffer (dma_buf)

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




IMO, One way to do this is adding field 'struct device *dev' to struct
vb2_queue. This field should be filled by a driver prior to calling
vb2_queue_init.

I haven't looked into the details, but that sounds good to me. Do we have use
cases where a queue is allocated before knowing which physical device it will
be used for ?


I don't think so. In case of S5P drivers, vb2_queue_init is called while opening /dev/videoX.

BTW. This struct device may help vb2 to produce logs with more descriptive client annotation.

What happens if such a device is NULL. It would happen for vmalloc allocator used by VIVI?

Regards,
Tomasz Stanislawski
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux