Re: [PATCH 13/23] omap3isp: Add lane configuration to platform data

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Laurent,

Thanks for the review!

On Mon, Jan 16, 2012 at 03:08:26PM +0100, Laurent Pinchart wrote:
> On Wednesday 11 January 2012 22:26:50 Sakari Ailus wrote:
> > Add lane configuration (order of clock and data lane) to platform data on
> > both CCP2 and CSI-2.
> > 
> > Signed-off-by: Sakari Ailus <sakari.ailus@xxxxxx>
> > ---
> >  drivers/media/video/omap3isp/ispcsiphy.h |   15 ++-------------
> >  include/media/omap3isp.h                 |   25 +++++++++++++++++++++++++
> >  2 files changed, 27 insertions(+), 13 deletions(-)
> > 
> > diff --git a/drivers/media/video/omap3isp/ispcsiphy.h
> > b/drivers/media/video/omap3isp/ispcsiphy.h index 9596dc6..e93a661 100644
> > --- a/drivers/media/video/omap3isp/ispcsiphy.h
> > +++ b/drivers/media/video/omap3isp/ispcsiphy.h
> > @@ -27,22 +27,11 @@
> >  #ifndef OMAP3_ISP_CSI_PHY_H
> >  #define OMAP3_ISP_CSI_PHY_H
> > 
> > +#include <media/omap3isp.h>
> > +
> >  struct isp_csi2_device;
> >  struct regulator;
> > 
> > -struct csiphy_lane {
> > -	u8 pos;
> > -	u8 pol;
> > -};
> > -
> > -#define ISP_CSIPHY2_NUM_DATA_LANES	2
> > -#define ISP_CSIPHY1_NUM_DATA_LANES	1
> > -
> > -struct isp_csiphy_lanes_cfg {
> > -	struct csiphy_lane data[ISP_CSIPHY2_NUM_DATA_LANES];
> > -	struct csiphy_lane clk;
> > -};
> > -
> >  struct isp_csiphy_dphy_cfg {
> >  	u8 ths_term;
> >  	u8 ths_settle;
> > diff --git a/include/media/omap3isp.h b/include/media/omap3isp.h
> > index 9c1a001..bc14099 100644
> > --- a/include/media/omap3isp.h
> > +++ b/include/media/omap3isp.h
> > @@ -91,6 +91,29 @@ enum {
> >  };
> > 
> >  /**
> > + * struct isp_csiphy_lane: CCP2/CSI2 lane position and polarity
> > + * @pos: position of the lane
> > + * @pol: polarity of the lane
> > + */
> > +struct isp_csiphy_lane {
> > +	u8 pos;
> > +	u8 pol;
> > +};
> > +
> > +#define ISP_CSIPHY2_NUM_DATA_LANES	2
> > +#define ISP_CSIPHY1_NUM_DATA_LANES	1
> 
> Any reason not to put CSIPHY1 first ? :-)

Yes. I believe wrote it that way. ;-)

I'll change it.

> With that modification,
> 
> Acked-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx>

Thanks!

-- 
Sakari Ailus
e-mail: sakari.ailus@xxxxxx	jabber/XMPP/Gmail: sailus@xxxxxxxxxxxxxx
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux