On Monday 16 January 2012 14:00:00 Oliver Neukum wrote: > Am Montag, 16. Januar 2012, 13:29:18 schrieb Hans Verkuil: > > From: Hans Verkuil <hans.verkuil@xxxxxxxxx> > > > > Signed-off-by: Hans Verkuil <hans.verkuil@xxxxxxxxx> > > --- > > > > drivers/media/video/v4l2-ctrls.c | 2 +- > > 1 files changed, 1 insertions(+), 1 deletions(-) > > > > diff --git a/drivers/media/video/v4l2-ctrls.c > > b/drivers/media/video/v4l2-ctrls.c index da1f4c2..35316f9 100644 > > --- a/drivers/media/video/v4l2-ctrls.c > > +++ b/drivers/media/video/v4l2-ctrls.c > > @@ -588,7 +588,7 @@ const char *v4l2_ctrl_get_name(u32 id) > > > > case V4L2_CID_PILOT_TONE_ENABLED: return "Pilot Tone Feature Enabled"; > > case V4L2_CID_PILOT_TONE_DEVIATION: return "Pilot Tone Deviation"; > > case V4L2_CID_PILOT_TONE_FREQUENCY: return "Pilot Tone Frequency"; > > > > - case V4L2_CID_TUNE_PREEMPHASIS: return "Pre-emphasis settings"; > > + case V4L2_CID_TUNE_PREEMPHASIS: return "Pre-Emphasis"; > > > > case V4L2_CID_TUNE_POWER_LEVEL: return "Tune Power Level"; > > case V4L2_CID_TUNE_ANTENNA_CAPACITOR: return "Tune Antenna Capacitor"; > > This looks like generic code. What happens if a programm is looking for > this string? User space can't rely on the name being constant. Perhaps in the future they can but not at the moment. Regards, Hans -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
