On Sat, 14 Jan 2012 18:42:20 +0100 Sylwester Nawrocki <sylvester.nawrocki@xxxxxxxxx> wrote: > Thank you for reviewing the patches. I wasn't sure I fully understood > the locking, hence I left the 'quality' field in 'struct sd' not removed. > I've modified both subdrivers according to your suggestions. I would have > one question before I send the corrected patches though. Unlike zc3xx, > the configured quality value in sonixj driver changes dynamically, i.e. > it drifts away in few seconds from whatever value the user sets. This makes > me wonder if .set_control operation should be implemented for the QUALITY > control, and whether to leave V4L2_CTRL_FLAG_READ_ONLY control flag or not. > > There seem to be not much value in setting such control for the user, > but maybe it's different for other devices covered by the sonixj driver. Setting the JPEG quality in sonixj has been removed when automatic quality adjustment has been added (git commit b96cfc33e7). At this time, I let the JPEG get function, but it could have been removed as well: I don't think the users are interested by this quality, and the applications may find it looking at the quantization tables of the images. Otherwise, letting the users/applications to set this quality is dangerous: if the quality is too high, the images cannot be fully transmitted because their size is too big for the USB 1.1 channel. So, IMO, you should let the sonixj as it is, and I will remove the get_jepgcomp. -- Ken ar c'hentañ | ** Breizh ha Linux atav! ** Jef | http://moinejf.free.fr/ -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
