Re: [PATCH] [media] s5p-fimc: Fix incorrect control ID assignment

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Acked-by: Kyungmin Park <kyungmin.park@xxxxxxxxxxx>

On 1/10/12, Sachin Kamat <sachin.kamat@xxxxxxxxxx> wrote:
> This patch fixes the mismatch between control IDs (CID) and controls
> for hflip, vflip and rotate.
>
> Signed-off-by: Sachin Kamat <sachin.kamat@xxxxxxxxxx>
> ---
>  drivers/media/video/s5p-fimc/fimc-core.c |    6 +++---
>  1 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/media/video/s5p-fimc/fimc-core.c
> b/drivers/media/video/s5p-fimc/fimc-core.c
> index 07c6254..170f791 100644
> --- a/drivers/media/video/s5p-fimc/fimc-core.c
> +++ b/drivers/media/video/s5p-fimc/fimc-core.c
> @@ -811,11 +811,11 @@ int fimc_ctrls_create(struct fimc_ctx *ctx)
>  	v4l2_ctrl_handler_init(&ctx->ctrl_handler, 3);
>
>  	ctx->ctrl_rotate = v4l2_ctrl_new_std(&ctx->ctrl_handler, &fimc_ctrl_ops,
> -				     V4L2_CID_HFLIP, 0, 1, 1, 0);
> +					V4L2_CID_ROTATE, 0, 270, 90, 0);
>  	ctx->ctrl_hflip = v4l2_ctrl_new_std(&ctx->ctrl_handler, &fimc_ctrl_ops,
> -				    V4L2_CID_VFLIP, 0, 1, 1, 0);
> +					V4L2_CID_HFLIP, 0, 1, 1, 0);
>  	ctx->ctrl_vflip = v4l2_ctrl_new_std(&ctx->ctrl_handler, &fimc_ctrl_ops,
> -				    V4L2_CID_ROTATE, 0, 270, 90, 0);
> +					V4L2_CID_VFLIP, 0, 1, 1, 0);
>  	ctx->ctrls_rdy = ctx->ctrl_handler.error == 0;
>
>  	return ctx->ctrl_handler.error;
> --
> 1.7.4.1
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-media" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux