On Wednesday 11 January 2012 11:23:24 Laurent Pinchart wrote: > Hi Hans, > > On Wednesday 11 January 2012 10:54:20 Hans Verkuil wrote: > > Building as3645a.c using media_build on kernel 3.2 gives this error: > > > > media_build/v4l/as3645a.c: In function 'as3645a_probe': > > media_build/v4l/as3645a.c:815:2: error: implicit declaration of function > > 'kzalloc' [-Werror=implicit-function-declaration] > > media_build/v4l/as3645a.c:815:8: warning: assignment makes pointer from > > integer without a cast [enabled by default] > > media_build/v4l/as3645a.c:842:3: error: implicit declaration of function > > 'kfree' [-Werror=implicit-function-declaration] cc1: some warnings being > > treated as errors > > > > The fix is trivial: > > > > diff --git a/drivers/media/video/as3645a.c > > b/drivers/media/video/as3645a.c index ec859a5..f241702 100644 > > --- a/drivers/media/video/as3645a.c > > +++ b/drivers/media/video/as3645a.c > > @@ -29,6 +29,7 @@ > > > > #include <linux/i2c.h> > > #include <linux/module.h> > > #include <linux/mutex.h> > > > > +#include <linux/slab.h> > > > > #include <media/as3645a.h> > > #include <media/v4l2-ctrls.h> > > > > Signed-off-by: Hans Verkuil <hans.verkuil@xxxxxxxxx> > > I got the same fix queued up in my tree already. Should I consider I have > your ack ? :-) Yup! Regards, Hans -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
