Hi Sakari,
Thanks for the patch.
On Tuesday 20 December 2011 21:28:01 Sakari Ailus wrote:
> From: Sakari Ailus <sakari.ailus@xxxxxx>
>
> smiapp_pad_ops.validate_pipeline is intended to validate the full pipeline
> which is implemented by the driver to which the subdev implementing this op
> belongs to.
Should this be documented in Documentation/video4linux/v4l2-framework.txt ?
> The validate_pipeline op must also call validate_pipeline on any external
> entity which is linked to its sink pads.
I'm uncertain about this. Subdev drivers would then have to implement the
pipeline walk logic, resulting in duplicate code. Our current situation isn't
optimal either: walking the pipeline should be implemented in the media code.
Would it suit your needs if the validate_pipeline operation was replaced by a
validate_link operation, with a media_pipeline_validate() function in the
media core to walk the pipeline and call validate_link in each pad (or maybe
each sink pad) ?
> Signed-off-by: Sakari Ailus <sakari.ailus@xxxxxx>
> ---
> include/media/v4l2-subdev.h | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/include/media/v4l2-subdev.h b/include/media/v4l2-subdev.h
> index 26eeaa4..a5ebe86 100644
> --- a/include/media/v4l2-subdev.h
> +++ b/include/media/v4l2-subdev.h
> @@ -470,6 +470,7 @@ struct v4l2_subdev_pad_ops {
> struct v4l2_subdev_selection *sel);
> int (*set_selection)(struct v4l2_subdev *sd, struct v4l2_subdev_fh *fh,
> struct v4l2_subdev_selection *sel);
> + int (*validate_pipeline)(struct v4l2_subdev *sd);
> };
>
> struct v4l2_subdev_ops {
--
Regards,
Laurent Pinchart
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
