Hi Sakari,
On Thursday 05 January 2012 10:10:19 Sakari Ailus wrote:
> Check media bus code on links. The user could configure different formats
> at different ends of the link, say, 8 bits-per-pixel in the source and 10
> bits-per-pixel in the sink. This leads to interesting and typically
> undesired results image-wise.
>
> Signed-off-by: Sakari Ailus <sakari.ailus@xxxxxx>
> ---
> drivers/media/video/omap3isp/ispvideo.c | 3 ++-
> 1 files changed, 2 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/media/video/omap3isp/ispvideo.c
> b/drivers/media/video/omap3isp/ispvideo.c index 615dae5..dbdd5b4 100644
> --- a/drivers/media/video/omap3isp/ispvideo.c
> +++ b/drivers/media/video/omap3isp/ispvideo.c
> @@ -352,7 +352,8 @@ static int isp_video_validate_pipeline(struct
> isp_pipeline *pipe)
>
> /* Check if the two ends match */
> if (fmt_source.format.width != fmt_sink.format.width ||
> - fmt_source.format.height != fmt_sink.format.height)
> + fmt_source.format.height != fmt_sink.format.height ||
> + fmt_source.format.code != fmt_sink.format.code)
If you scroll down a bit, the check is already present in the second branch of
the if statement. The reason why the driver doesn't enforce the same format
unconditionally is that the lane shifter on the CCDC sink link can shift data,
so a special check is needed there.
> return -EPIPE;
>
> if (shifter_link) {
--
Regards,
Laurent Pinchart
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
