Hi Scott, Thanks for the patch. On Wed, Dec 21, 2011 at 10:30:54AM -0500, Scott Jiang wrote: > list_is_singular accepts a list head to test whether a list has just one entry. > fh->list is the entry, fh->vdev->fh_list is the list head. > > Signed-off-by: Scott Jiang <scott.jiang.linux@xxxxxxxxx> > --- > drivers/media/video/v4l2-fh.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/drivers/media/video/v4l2-fh.c b/drivers/media/video/v4l2-fh.c > index 9e3fc04..8292c4a 100644 > --- a/drivers/media/video/v4l2-fh.c > +++ b/drivers/media/video/v4l2-fh.c > @@ -113,7 +113,7 @@ int v4l2_fh_is_singular(struct v4l2_fh *fh) > if (fh == NULL || fh->vdev == NULL) > return 0; > spin_lock_irqsave(&fh->vdev->fh_lock, flags); > - is_singular = list_is_singular(&fh->list); > + is_singular = list_is_singular(&fh->vdev->fh_list); > spin_unlock_irqrestore(&fh->vdev->fh_lock, flags); > return is_singular; > } Is there an issue that this patch resolves, or am I missing something? As far as I can see, the list_is_singular() test returns the same result whether you are testing a list item which is part of the list, or its head in struct video_device. Kind regards, -- Sakari Ailus e-mail: sakari.ailus@xxxxxx jabber/XMPP/Gmail: sailus@xxxxxxxxxxxxxx -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
