Re: [GIT PATCHES FOR 3.3] gspca patches and new jl2005bcd driver

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, 30 Dec 2011 10:29:56 +0100
Hans de Goede <hdegoede@xxxxxxxxxx> wrote:
	[snip]
> The following changes since commit 1a5cd29631a6b75e49e6ad8a770ab9d69cda0fa2:
> 
>    [media] tda10021: Add support for DVB-C Annex C (2011-12-20 14:01:08 -0200)
> 
> are available in the git repository at:
>    git://linuxtv.org/hgoede/gspca.git media-for_v3.3
	[snip]
> Theodore Kilgore (1):
>        gspca: add jl2005bcd sub driver
	[snip]

I have noticed some problems with the patch 2346c78dff71b003f:

- there should be no change in gspca.h (addition of two empty lines)

- there is no documentation about the new pixel format 'JL20'

- in jl2005bcd.c, the macro 'err' is used instead of 'pr_err'
  (there are also spaces at end of line, but this is less important..)

-- 
Ken ar c'hentañ	|	      ** Breizh ha Linux atav! **
Jef		|		http://moinejf.free.fr/
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux