Hi, On 12/30/2011 07:35 AM, HeungJun, Kim wrote:
Hi Sakari, Thanks for the comments! Your comments help me to order my thoughts and re-send RFC.
<snip>
The value of the new control would have an effect as long as automatic white balance is enabled.No, it's a kind of Manual White Balance, not Auto. It's the same level of V4L2_CID_WHITE_BALANCE_TEMPERATURE. So, only when V4L2_CID_AUTO_WHITE_BALANCE is disabled, this control is enabled. The relationship between each white balance controls by my understanding is here. Auto White Balance - V4L2_CID_AUTO_WHITE_BALANCE(Boolean) : enable/disable Auto white balance. : Enable means current mode is Auto, and disable means current mode is Manual Manual White Balance - V4L2_CID_WHITE_BALANCE_TEMPERATURE(integer) : Setting the temperature of Manual : Only when the V4L2_CID_AUTO_WHITE_BALANCE is disabled, and current mode Manual. - V4L2_CID_WHITE_BALANCE_PRESET(menu) - I suggested : Setting the specific temperature value(but, the value is not fetched by user) of Manual : Only when the V4L2_CID_AUTO_WHITE_BALANCE is disabled, and current mode Manual. The "input" is right. And, this "input" just triggers the ISP(sensor) set the specific manual white balance value embedded in the ISP. I think this control does not affect the Auto White Balance.
Right, so the above is exactly why I ended up making the pwc whitebalance control the way it is, the user can essentially choice between a number of options: 1) auto whitebal 2) a number of preset whitebal values (seems your proposal has some more then the pwc driver, which is fine) 3) manual whitebal, at which point the user may set whitebal through one of: a) a color temperature control b) red and blue balance controls c) red, green and blue gains Notice that we also need to add some standardized controls for the 3c case, but that is a different discussion. Seeing how this discussion has evolved I believe that what I did in the pwc driver is actually right from the user pov, the user gets one simple menu control which allows the user to choice between auto / preset 1 - x / manual and since as described above choosing one of the options excludes the other options from being active I believe having this all in one control is the right thing to do. Regards, Hans -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
