On 27.12.2011 02:08, Mauro Carvalho Chehab wrote:
> There's no need to initialize unused fields with zero, as Kernel does
> it automatically. Don't do that, in order to save some space at the
> data segment.
No space is saved for members of a struct, unless the complete struct is
initialized to zero.
Anyway, it improves readability.
> This also allows the removal of the unused pll_set callback.
>
> Signed-off-by: Mauro Carvalho Chehab <mchehab@xxxxxxxxxx>
> ---
> drivers/media/video/em28xx/em28xx-dvb.c | 10 ++++++----
> 1 files changed, 6 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/media/video/em28xx/em28xx-dvb.c b/drivers/media/video/em28xx/em28xx-dvb.c
> index 3868c1e..28be043 100644
> --- a/drivers/media/video/em28xx/em28xx-dvb.c
> +++ b/drivers/media/video/em28xx/em28xx-dvb.c
> @@ -302,10 +302,12 @@ static struct zl10353_config em28xx_zl10353_xc3028_no_i2c_gate = {
> };
>
> static struct drxd_config em28xx_drxd = {
> - .index = 0, .demod_address = 0x70, .demod_revision = 0xa2,
> - .demoda_address = 0x00, .pll_address = 0x00,
> - .pll_type = DRXD_PLL_NONE, .clock = 12000, .insert_rs_byte = 1,
> - .pll_set = NULL, .osc_deviation = NULL, .IF = 42800000,
> + .demod_address = 0x70,
> + .demod_revision = 0xa2,
> + .pll_type = DRXD_PLL_NONE,
> + .clock = 12000,
> + .insert_rs_byte = 1,
> + .IF = 42800000,
> .disable_i2c_gate_ctrl = 1,
> };
>
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
