Hi Antti, On Thursday, December 22, 2011 10:30:25 PM Antti Palosaari wrote: > Rename DMB-TH to DTMB. > > Add few new values for existing parameters. > > Add two new parameters, interleaving and carrier. > DTMB supports interleavers: 240 and 720. > DTMB supports carriers: 1 and 3780. > > Signed-off-by: Antti Palosaari <crope@xxxxxx> > --- > drivers/media/dvb/dvb-core/dvb_frontend.c | 19 ++++++++++++++++++- > drivers/media/dvb/dvb-core/dvb_frontend.h | 3 +++ > include/linux/dvb/frontend.h | 13 +++++++++++-- > include/linux/dvb/version.h | 2 +- > 4 files changed, 33 insertions(+), 4 deletions(-) > > diff --git a/drivers/media/dvb/dvb-core/dvb_frontend.c > b/drivers/media/dvb/dvb-core/dvb_frontend.c > index 821b225..ec2cbae 100644 > --- a/drivers/media/dvb/dvb-core/dvb_frontend.c > +++ b/drivers/media/dvb/dvb-core/dvb_frontend.c > @@ -924,6 +924,8 @@ static struct dtv_cmds_h dtv_cmds[DTV_MAX_COMMAND + > 1] = { > _DTV_CMD(DTV_CODE_RATE_LP, 1, 0), > _DTV_CMD(DTV_GUARD_INTERVAL, 1, 0), > _DTV_CMD(DTV_TRANSMISSION_MODE, 1, 0), > + _DTV_CMD(DTV_CARRIER, 1, 0), What would you think if instead of adding DTV_CARRIER (which indicates whether we are using single carrier or multi carrier, if I understand it correctly) we add a TRANSMISSION_MODE_SC. Then TRANSMISSION_MODE_4K is the multi-carrier mode and TRANSMISSION_MODE_SC is the single-carrier mode. We save a new DTV-command. I'm not making a secret of it, this is how we handled this inside DiBcom and it would simplify the integration of our drivers for this standard. This is planned to be done during the first half of 2012. Comments? -- Patrick Boettcher - KernelLabs http://www.kernellabs.com/ -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html