Re: Add tuner_type to zl10353 config and use it for reporting signal directly from tuner.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 12/21/2011 11:07 PM, Miroslav Slugeň wrote:
XC4000 based cards are not using AGC control in normal way, so it is
not possible to get signal level from AGC registres of zl10353
demodulator, instead of this i send previous patch to implement signal
level directly in xc4000 tuner and now sending patch for zl10353 to
implement this future for digital mode. Signal reporting is very
accurate and was well tested on 3 different Leadtek XC4000 cards.

I don't like that patch at all. My opinion is that you should put hacks like to the interface driver. Override demod .read_signal_strength() callback and route it to the tuner callback. No any changes for the demod driver should be done.

Estimation of the signal strength is a little bit hard when looking demod point of view. Demod gets IF as input signal and thus have mainly idea of IF AGC values. Estimating RF strength is thus very inaccurate from the IF AGC gain. And those IF AGC values are tuner/demod combination dependent too. Sometimes there is also RF AGC available for the demod. With both IF and RF AGC you could estimate more better - but still very inaccurate.


regards
Antti
--
http://palosaari.fi/
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux