On 05-12-2011 13:40, Zhu, Mingcheng wrote:
Hi Mauro and Hans, For our MSM chipset family we will have multiple capture device drivers. There are two directory layout approaches as: Tree type directory structure: * /video/msm/camera: for camera driver * /video/msm/wfd: for our wfd driver * Etc. Flat directory structure: * /video/msm: for our existing camera driver * /video/msm_wfd: for our new wfd driver Both have pros and cons. The tree directory structure groups msm family drivers well but less readable than the flat directory structure. However, the flat directory structure floods the /video directory when all venders add more drivers into it. What approach do you suggest/prefer? Looking forward to getting your reply.
Not sure if I understood your question. If by "msm/camera" you're meaning the sensors drivers, we're currently putting all camera sensors at /drivers/media/video. I don't see any reason why those should be under drivers/media/video/msm (or whatever inside it). Those drivers should use the V4L2 subdev approach and be capable of being re-used on other drivers, as we don't want to have duplicated efforts to maintain them at the kernel. Eventually, we might, in the future, move all of them to some sensor-specific directory. If you're just referring to two different drivers, it is basically up to you to choose whatever fits better. If they don't share any common code, it makes sense to have one different directory under /video. We do this already. For example, there are several supported Conexant chipsets. Each has their own directory, as they're completely independent designs and don't share any code between them (well, except for the risc code generator at drivers/media/video/btcx-risc.c that is shared by both bttv and cx88 drivers). On the other hand, if the drivers share several common stuff that are specific for the MSM chipset, it is likely better to do: .../video/msm/common .../video/msm/wfd ... E. g. one directory for each driver, and a common directory with the shared modules. Regards, Mauro -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
