Re: [PATCH 3/5] tm6000: bugfix interrupt reset

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



* Mauro Carvalho Chehab wrote:
> On 05-12-2011 05:21, Thierry Reding wrote:
> >* linuxtv@xxxxxxxxxxxxxxx wrote:
> >>From: Stefan Ringel<linuxtv@xxxxxxxxxxxxxxx>
> >>
> >>Signed-off-by: Stefan Ringel<linuxtv@xxxxxxxxxxxxxxx>
> >
> >Your commit message needs more details. Why do you think this is a bugfix?
> >Also this commit seems to effectively revert (and then partially reimplement)
> >a patch that I posted some months ago.
> 
> Thierry,
> 
> I noticed this. I tested tm6000 with those changes with both the first gen
> tm5600 devices I have and HVR900H and I didn't notice any bad thing with this
> approach, and changing from one standard to another is now faster.
> 
> So, I decided to apply it (with the remaining patches I've made to
> fix audio for PAL/M and NTSC/M).
> 
> I also noticed that TM6000_QUIRK_NO_USB_DELAY is not needed anymore
> (still, Stefan's patches didn't remove it completely).
> 
> Could you please test if the problems you've solved with your approach
> are still occurring?

Unfortunately I don't have any hardware available anymore. I will see if I
can get my hands on some of the devices, but that may take a while. I guess
you'll just have to apply without me testing them first. My comments should
be addressed anyway, though.

Thierry

Attachment: pgpwKVES4mZ9B.pgp
Description: PGP signature


[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux