Hi Sakari, On Thu, Dec 1, 2011 at 10:14 AM, Sakari Ailus <sakari.ailus@xxxxxx> wrote: > Hi Sergio, > > Thanks for the patchset!! And thanks for your attention :) > > On Wed, Nov 30, 2011 at 06:14:49PM -0600, Sergio Aguirre wrote: >> Hi everyone, >> >> This is the second version of the OMAP4 ISS driver, >> now ported to the Media Controller framework AND supporting >> videobuf2 framework. >> >> This patchset should apply cleanly on top of v3.2-rc3 kernel tag. >> >> This driver attempts to provide an fully open source solution to >> control the OMAP4 Imaging SubSystem (a.k.a. ISS). >> >> Starts with just CSI2-A interface support, and pretends to be >> ready for expansion to add support to the many ISS block modules >> as possible. >> >> Please see newly added documentation for more details: >> >> Documentation/video4linux/omap4_camera.txt > > I propose s/omap4_camera/omap4iss/, according to the path name in the > drivers/media/video directory. Makes sense. Will fix. > >> Any comments/complaints are welcome. :) >> >> Changes since v1: >> - Simplification of auxclk handling in board files. (Pointed out by: Roger Quadros) >> - Cleanup of Camera support enablement for 4430sdp & panda. (Pointed out by: Roger Quadros) >> - Use of HWMOD declaration for assisted platform_device creation. (Pointed out by: Felipe Balbi) >> - Videobuf2 migration (Removal of custom iss_queue buffer handling driver) > > I'm happy to see it's using videobuf2! Yeah, I'll definitely need it for multi-planar buffer handling for NV12 buffer capturing. Resizer can color convert from YUV422->YUV420 NV12 now, and expects 2 pointers (1 for Y, and 1 for UV 2x2 sampled) to be programmed in HW. > > I have no other comments quite yet. :-) Ok, let me know if you find something eye-popping ugly in there. I'll be happy to fix it. :) Thanks and Regards, Sergio > > Cheers, > > -- > Sakari Ailus > e-mail: sakari.ailus@xxxxxx jabber/XMPP/Gmail: sailus@xxxxxxxxxxxxxx -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
