Em 23-11-2011 05:09, Dan Carpenter escreveu:
> The msg->command field is 32 bits, and we should fill it with a call
> to cpu_to_le32(). The current code is broken on big endian systems,
> and on little endian systems it just truncates the 32 bit value to
> 16 bits.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
> ---
> This is a static checker bug. I haven't tested it.
>
> diff --git a/drivers/media/video/saa7164/saa7164-bus.c b/drivers/media/video/saa7164/saa7164-bus.c
> index 466e1b0..8f853d1 100644
> --- a/drivers/media/video/saa7164/saa7164-bus.c
> +++ b/drivers/media/video/saa7164/saa7164-bus.c
> @@ -149,7 +149,7 @@ int saa7164_bus_set(struct saa7164_dev *dev, struct tmComResInfo* msg,
> saa7164_bus_verify(dev);
>
> msg->size = cpu_to_le16(msg->size);
> - msg->command = cpu_to_le16(msg->command);
> + msg->command = cpu_to_le32(msg->command);
> msg->controlselector = cpu_to_le16(msg->controlselector);
>
> if (msg->size > dev->bus.m_wMaxReqSize) {
Hmm... I don't have this hardware, but:
peekout:
msg->size = le16_to_cpu(msg->size);
msg->command = le16_to_cpu(msg->command);
msg->controlselector = le16_to_cpu(msg->controlselector);
ret = SAA_OK;
out:
mutex_unlock(&bus->lock);
saa7164_bus_verify(dev);
return ret;
}
le16_to_cpu() is used for command. If one place needs fix, so the other one also
requires it.
Regards,
Mauro
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
