On Fri, Nov 25, 2011 at 11:28:46AM +0100, Laurent Pinchart wrote:
> Hi Sakari,
>
> Thanks for the patch.
Hi Laurent,
Thanks for the comments!
> On Thursday 24 November 2011 17:12:50 Sakari Ailus wrote:
...
> > @@ -1440,12 +1458,13 @@ struct v4l2_ctrl *v4l2_ctrl_new_std_menu(struct
> > v4l2_ctrl_handler *hdl, u32 flags;
> >
> > v4l2_ctrl_fill(id, &name, &type, &min, &max, &step, &def, &flags);
> > - if (type != V4L2_CTRL_TYPE_MENU) {
> > + if (type != V4L2_CTRL_TYPE_MENU
> > + && type != V4L2_CTRL_TYPE_INTEGER_MENU) {
> > handler_set_err(hdl, -EINVAL);
> > return NULL;
> > }
> > return v4l2_ctrl_new(hdl, ops, id, name, type,
> > - 0, max, mask, def, flags, qmenu, NULL);
> > + 0, max, mask, def, flags, qmenu, NULL, NULL);
>
> You pass NULL to the v4l2_ctrl_new() qmenu_int argument, which will make the
> function fail for integer menu controls. Do you expect standard integer menu
> controls to share a list of values ? If not, what about modifying
> v4l2_ctrl_new_std_menu() to take a list of values (or alternatively forbidding
> the function from being used for integer menu controls) ?
We currently have no integer menu controls, let alone one which would have a
set of standard values. We need same functionality as in
v4l2_ctrl_get_menu() for integer menus when we add the first standardised
integer menu control. I think it could be added at that time, or I could
implement a v4l2_ctrl_get_integer_menu() which would do nothing.
What do you think?
--
Sakari Ailus
e-mail: sakari.ailus@xxxxxx jabber/XMPP/Gmail: sailus@xxxxxxxxxxxxxx
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
