Hi Sascha, I was just trying to fix the issues you pointed previously and I have a question for you. On 22 November 2011 21:55, Sascha Hauer <s.hauer@xxxxxxxxxxxxxx> wrote: > Hi Javier, >> + >> +static int emmaprp_probe(struct platform_device *pdev) >> +{ >> + struct emmaprp_dev *pcdev; >> + struct video_device *vfd; >> + struct resource *res_emma; >> + int irq_emma; >> + int ret; >> + >> + pcdev = kzalloc(sizeof *pcdev, GFP_KERNEL); >> + if (!pcdev) >> + return -ENOMEM; >> + >> + spin_lock_init(&pcdev->irqlock); >> + >> + pcdev->clk_emma = clk_get(NULL, "emma"); > > You should change the entry for the emma in > arch/arm/mach-imx/clock-imx27.c to the following: > > _REGISTER_CLOCK("m2m-emmaprp", NULL, emma_clk) > > and use clk_get(&pdev->dev, NULL) here. > Is this what you are asking for? --- a/arch/arm/mach-imx/clock-imx27.c +++ b/arch/arm/mach-imx/clock-imx27.c @@ -661,7 +661,7 @@ static struct clk_lookup lookups[] = { _REGISTER_CLOCK(NULL, "dma", dma_clk) _REGISTER_CLOCK(NULL, "rtic", rtic_clk) _REGISTER_CLOCK(NULL, "brom", brom_clk) - _REGISTER_CLOCK(NULL, "emma", emma_clk) + _REGISTER_CLOCK("m2m-emmaprp", NULL, emma_clk) _REGISTER_CLOCK(NULL, "slcdc", slcdc_clk) _REGISTER_CLOCK("imx27-fec.0", NULL, fec_clk) _REGISTER_CLOCK(NULL, "emi", emi_clk) If I do that, mx2_camera.c will stop working. Furthermore it does not work for this driver either (I get an error on clk_get() ). -- Javier Martin Vista Silicon S.L. CDTUC - FASE C - Oficina S-345 Avda de los Castros s/n 39005- Santander. Cantabria. Spain +34 942 25 32 60 www.vista-silicon.com -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html