On Wed, 2011-11-16 at 15:10 +0100, Laurent Pinchart wrote:
> This patch adds the driver for the as3645a LED flash controller. This
> controller supports a high power led in flash and torch modes and an
> indicator light, sometimes also called privacy light.
Just few nitpicks.
> diff --git a/drivers/media/video/Kconfig b/drivers/media/video/Kconfig
> index 4e8a0c4..9617c05 100644
> --- a/drivers/media/video/Kconfig
> +++ b/drivers/media/video/Kconfig
> @@ -533,6 +533,13 @@ config VIDEO_ADP1653
> This is a driver for the ADP1653 flash controller. It is used for
> example in Nokia N900.
>
> +config VIDEO_AS3645A
> + tristate "AS3645A flash driver support"
> + depends on I2C && VIDEO_V4L2 && MEDIA_CONTROLLER
> + ---help---
> + This is a driver for the AS3645A and LM3555 flash controllers. It has
> + build in control for Flash, Torch and Indicator LEDs.
Probably we might use uncapitalized words "for flash, torch and
indicator"
> diff --git a/drivers/media/video/as3645a.c b/drivers/media/video/as3645a.c
> new file mode 100644
> index 0000000..d583a9c
> --- /dev/null
> +++ b/drivers/media/video/as3645a.c
> +static int as3645a_probe(struct i2c_client *client,
> + const struct i2c_device_id *devid)
> +{
To be consistent with remove()
+ mutex_init(&flash->power_lock);
> + ret = as3645a_init_controls(flash);
> + if (ret < 0)
> + goto done;
> +
> + ret = media_entity_init(&flash->subdev.entity, 0, NULL, 0);
> + if (ret < 0)
> + goto done;
> +
> + flash->subdev.entity.type = MEDIA_ENT_T_V4L2_SUBDEV_FLASH;
> + flash->led_mode = V4L2_FLASH_LED_MODE_NONE;
> +
> +done:
> + if (ret < 0) {
+ mutex_destroy(&flash->power_lock);
> + v4l2_ctrl_handler_free(&flash->ctrls);
> + kfree(flash);
> + }
> +
> + return ret;
> +}
--
Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
Intel Finland Oy
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
