Hi Andy, Thanks for the patch. On Tuesday 15 November 2011 18:49:54 Andy Shevchenko wrote: > The as3645a_registered() is used to detect connected chip. It would be nice > to print the detected value every time we load the module. The "Vendor" is > probably better word to use there. For example, lm3555 (NSC) is slightly > different to as3645a. > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx> > --- > drivers/media/video/as3645a.c | 4 ++-- > 1 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/media/video/as3645a.c b/drivers/media/video/as3645a.c > index ef1226d..8882a14 100644 > --- a/drivers/media/video/as3645a.c > +++ b/drivers/media/video/as3645a.c > @@ -602,8 +602,8 @@ static int as3645a_registered(struct v4l2_subdev *sd) > factory = "Unknown"; > } > > - dev_dbg(&client->dev, "Factory: %s(%d) Version: %d\n", factory, man, > - version); > + dev_info(&client->dev, "Chip vendor: %s(%d) Version: %d\n", factory, > + man, version); I'll rename the factory variable to vendor. > rval = as3645a_write(flash, AS_PASSWORD_REG, AS_PASSWORD_UNLOCK_VALUE); > if (rval < 0) -- Regards, Laurent Pinchart -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
